fix: memory lane assets in ascending order #8309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying immich with
|
| Latest commit: |
aebc5a6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3ffc8cbc.immich.pages.dev |
| Branch Preview URL: | https://fix-8275.immich.pages.dev |
| @@ -131,7 +131,9 @@ export function mapAsset(entity: AssetEntity, options: AssetMapOptions = {}): As | |||
| } | |||
|
|
|||
| export class MemoryLaneResponseDto { | |||
| @ApiProperty({ deprecated: true }) | |||
| title!: string; | |||
There was a problem hiding this comment.
My initial thought for this property is that we will have more categories, not just x year ago, but perhaps the best shots of the month...etc.
There was a problem hiding this comment.
It doesn't work very well with translations though. I think sending back text in an API always gets complicated when dealing with i18n. We can probably add a type field if we start supporting another category of memories.
There was a problem hiding this comment.
Basically metadata and types are probably the easy to go and the clients can translate it into titles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
response.title(client can do this using translations andyearsAgo)