refactor(server): extract add/remove assets logic to utility function #8329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldietzler
force-pushed
the
refactor/bulk-asset-operations
branch
from
20f6a22
to
80b368d
Compare
Deploying immich with
|
| Latest commit: |
e0d0dc3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5c6d2d77.immich.pages.dev |
| Branch Preview URL: | https://refactor-bulk-asset-operatio.immich.pages.dev |
jrasm91
approved these changes
Mar 28, 2024
danieldietzler
force-pushed
the
refactor/bulk-asset-operations
branch
3 times, most recently
from
ed11f3f
to
5378181
Compare
jrasm91
reviewed
Mar 28, 2024
danieldietzler
force-pushed
the
refactor/bulk-asset-operations
branch
from
5378181
to
1f40862
Compare
jrasm91
reviewed
Mar 29, 2024
|
|
||
| const removedIds = results.filter(({ success }) => success).map(({ id }) => id); | ||
| if (removedIds.length > 0) { | ||
| await this.albumRepository.removeAssets(id, removedIds); |
There was a problem hiding this comment.
I don't think it's possible here since we need to answer two questions: (1) Did any ids actually get removed? (2) Was the thumbnail asset id part of those removed ids?
server/src/utils/asset.util.ts
Outdated
|
|
||
| const newAssetIds = results.filter(({ success }) => success).map(({ id }) => id); | ||
| if (newAssetIds.length > 0) { | ||
| await repository.addAssetIds(dto.id, dto.assetIds); |
There was a problem hiding this comment.
Is this a bug? Surely it should be the new asset IDs.
fix tests chore: generate sql foo
danieldietzler
force-pushed
the
refactor/bulk-asset-operations
branch
from
1f40862
to
e0d0dc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.