New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: persistent memories #8330
Conversation
Deploying immich with Cloudflare Pages
|
70aa3f1
to
6b6c71a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! :)
/** when the user last viewed the memory */ | ||
@Column({ type: 'timestamptz', nullable: true }) | ||
seenAt?: Date; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want these memories to be shared, do we want this to be handled at a user level?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are only going to be tracked for the owner. I'm not sure what functions shared users will be able to do besides view them in the future. Eventually we could do something like we have planned to do with assets and move owner id off of this table, but it seems premature to try to figure that out now, here.
/** unless set to true, will be automatically deleted in the future */ | ||
@Column({ default: false }) | ||
isSaved!: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly, do we want to store who it's saved by?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm planning on having this work like Google. So, we'll generate memories and unless the user clicks something to "save" it (set this to true) it will get automatically deleted after 14 days.
351adde
to
80848da
Compare
Do we address #8352 in this PR? |
No. This PR adds the foundation to support persistent memories (adds a new API for them) but it doesn't include automatic memory generation yet. I was planning to do that part in a follow-up pull request. |
Let's resolve the conflicts and merge it! |
80848da
to
9adb005
Compare
Dedicated endpoint, service, repository, and database entity for memories, with the goal to make it possible to share, save, and view in the future.
Other thoughts:
memoryAt
date field to track the "date" the memory represents. Memories are sorted descending by default so newest memories appear first