Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): add missing file extensions to library files #8342

Merged
merged 6 commits into from Mar 29, 2024
Merged

fix(server): add missing file extensions to library files #8342

merged 6 commits into from Mar 29, 2024

Conversation

etnoy
Copy link
Contributor

@etnoy etnoy commented Mar 28, 2024

  • Detect when the basename is invalid and force refresh
  • Actually re-import new filename upon refresh

This adds to #8083 and #8052 and makes a retroactive fix for all affected assets

@etnoy etnoy added 🗄️server external-library Issues related to external libraries labels Mar 28, 2024
@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Mar 28, 2024 •
edited

Deploying immich with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0edcc16
Status: ✅  Deploy successful!
Preview URL: https://a040dcdb.immich.pages.dev
Branch Preview URL: https://fix-add-library-file-extensi.immich.pages.dev

View logs

jrasm91
jrasm91 approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

server/src/services/library.service.ts Outdated Show resolved Hide resolved
mertalev
mertalev approved these changes Mar 29, 2024
View reviewed changes
server/src/services/library.service.ts Outdated Show resolved Hide resolved
server/src/services/library.service.ts Outdated Show resolved Hide resolved
server/src/services/library.service.ts Outdated Show resolved Hide resolved
server/src/services/library.service.ts Outdated Show resolved Hide resolved
server/src/services/library.service.ts Outdated Show resolved Hide resolved
@mertalev mertalev merged commit ec48fcc into main Mar 29, 2024
24 checks passed
@mertalev mertalev deleted the fix/add-library-file-extension branch March 29, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasm91 jrasm91 jrasm91 approved these changes

@mertalev mertalev mertalev approved these changes

Assignees
No one assigned
Labels
external-library Issues related to external libraries 🗄️server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etnoy @jrasm91 @mertalev