feat(web, a11y): add labels! #8354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bo0tzz
approved these changes
Mar 29, 2024
web/src/lib/components/elements/buttons/circle-icon-button.svelte
Outdated
Show resolved
Hide resolved
jrasm91
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Labeling icons + buttons in various locations!
Notable changes:
titleis now a required prop forCircleIconButton, and it automatically adds anaria-labelfor screen reader usersaria-hidden, because they already have perceivable text to go along with themScreenshots
N/A - UI looks visually the same.
How Has This Been Tested?
Hover over any of the change buttons with a mouse to check that a popup with the title appears. Or try using a screen reader to focus the buttons, and check if it announces a title.
Checklist: