feat(mobile): search enhancement #8392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich into mobile/search-enhancement
Deploying immich with
|
| Latest commit: |
91baeac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0c9e8fed.immich.pages.dev |
| Branch Preview URL: | https://mobile-search-enhancement.immich.pages.dev |
fyfrey
approved these changes
Apr 1, 2024
| }; | ||
| } | ||
|
|
||
| factory SearchLocationFilter.fromMap(Map<String, dynamic> map) { |
There was a problem hiding this comment.
Do we use/need to/fromMap and to/fromJson at all for the filter classes?
I think they are never used.
There was a problem hiding this comment.
No, they are not used. It is auto-generated. I use this extension on vscode to help generate these classes
https://marketplace.visualstudio.com/items?itemName=dotup.dart-data-class-generator
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the advanced search filters feature to the mobile app.
The result is fetched in batches of 1000, the infinite scrolling is janky due to the way the asset grid is built, so when a new batch is fetched, it rerenders the whole page. I might open a subsequent PR to address this issue
searchmobiledemo.mp4