fix(server): penalize null geodata fields when searching places #8408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test for
/search/placeswas recently made stricter by checking that the top result is the most relevant. However, it's actually not guaranteed to be the first result as Paris and Paris Leona are tied in score. The reason for this is that the latter has null foradmin2Name, which gets coalesced to 0 (a perfect match). This PR sets null values to have a score of 0.1 to avoid rewarding a lack of data.How Has This Been Tested?
Tested that the order for this is now deterministic and the test does not flake.