-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web,a11y): slider accessibility improvements #8479
Conversation
* add perceivable focus outline * label all sliders for screen readers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can we please keep the slider's original styling? |
I think it only changes the styling when the slider is focused. It makes it easier when you're tabbing through elements in the page, etc. |
web/src/lib/components/shared-components/settings/setting-switch.svelte
Outdated
Show resolved
Hide resolved
web/src/lib/components/shared-components/settings/setting-switch.svelte
Outdated
Show resolved
Hide resolved
Yes, I'm seeing that too. I will do some investigation to see if there's a good solution for that. |
So I've been looking into this @mertalev . Some things I've tried:
So... the compromise solution I could think of is adding a subtle border in the same color as the background, to mask the color artifacting. It also has the added benefit of making the slider a little easier to see when it's focused, in my opinion. What do you think about this solution? |
59dccc0
to
4e3a509
Compare
4e3a509
to
fd7859c
Compare
That looks a lot better! It's also good in that it increases contrast when the outline and slider are both gray. |
Description
Made the following accessibility changes to the
Slider
toggle component:Screenshots
Expand for screenshots
Focused slider in dark mode (Firefox)
Focused slider in light mode (Firefox)
How Has This Been Tested?
Try tabbing through a form with sliders, such as the "Create link to share" modal. There should be visible focus outlines around the slider.
Checklist: