fix(server): hevc tag being set when copying a non-hevc stream #8582
Conversation
Deploying immich with
|
| Latest commit: |
32acd14
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f777fdfd.immich.pages.dev |
| Branch Preview URL: | https://fix-server-hevc-tag.immich.pages.dev |
| if ( | ||
| this.config.targetVideoCodec === VideoCodec.HEVC && | ||
| (videoCodec !== 'copy' || videoStream.codecName === 'hevc') | ||
| ) { |
| outputOptions: [ | ||
| '-c:v copy', | ||
| '-c:a aac', | ||
| '-movflags faststart', |
There was a problem hiding this comment.
I have a little bit of concern--not directly relevant to this PR.
These tests seem too strict in that they compare every flag passed to ffmpeg, not only the essential one. Assume one day some default options like preset is changed, all these tests must be updated.
Maybe (if feasible) it is more flexible to only check the existence (and non-existence) of some arguments?
There was a problem hiding this comment.
Yes, it's very annoying haha. Even just changing the order of the flags breaks tests. I've been meaning to change them to be more targeted. The only thing is that the arguments to toHaveBeenCalledWith have to be a perfect match - you can't check certain fields or use objectContaining/arrayContaining. But I think checking the raw calls directly should work.
Description
Fixes the issue described in #8567