Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudflare OAuth Guide #8614

Closed
wants to merge 10 commits into from

Conversation

shanelord01
Copy link

Guide to setup immich with OAuth via Cloudflare Access

@danieldietzler danieldietzler added the documentation Improvements or additions to documentation label Apr 8, 2024
@bo0tzz
Copy link
Member

bo0tzz commented Apr 9, 2024

This is coming from #8299, right? How would you feel about instead adding a link to that discussion to the community projects page (https://immich.app/docs/community-projects)?

@shanelord01
Copy link
Author

This is coming from #8299, right? How would you feel about instead adding a link to that discussion to the community projects page (https://immich.app/docs/community-projects)?

I'm just going off the request to add it to the guides section as per #8299 (comment)

IMHO - it's not an add-on - it's a guide on how to configure OAuth.

@alextran1502 alextran1502 enabled auto-merge (squash) April 15, 2024 06:22
@bo0tzz bo0tzz disabled auto-merge April 15, 2024 06:35
@shanelord01
Copy link
Author

Do I need to do something to fix this merge error? If so - can you let me know what?

@mmomjian
Copy link
Contributor

This is coming from #8299, right? How would you feel about instead adding a link to that discussion to the community projects page (https://immich.app/docs/community-projects)?

I think this does fit better as a Guide, we have enough people on the team I believe that do use CloudFlare and it’s very popular with users as well. It’s not as esoteric as Podman, for example.

@bo0tzz
Copy link
Member

bo0tzz commented Apr 15, 2024

we have enough people on the team I believe that do use CloudFlare

I'm not aware of anyone on the team that is specifically using cloudflare oauth. There are also plenty of other things that team members do use for which we wouldn't want to add guides. In a discussion with the other maintainers this morning we decided not to include tool-specific guides like this inside our docs.

#8812 adds a new community guides section that also includes a link to #8299, so I'll close this PR in favour of that one.

@bo0tzz bo0tzz closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants