Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): loop video thumbnails #8662

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

lukashass
Copy link
Contributor

@lukashass lukashass commented Apr 9, 2024

Feels a lot more natural IMO.

@alextran1502
Copy link
Contributor

so it will loop like a gif?

@zackpollard
Copy link
Contributor

zackpollard commented Apr 9, 2024

so it will loop like a gif?

Yea it will just play again once it ends, LGTM, seems like a nice change

@Krolitian
Copy link

What if we have it enable looping only after clicking the restart button at the end of a video, and then it loops endlessly? It lets people enable looping videos without an additional toggle and lets other people not have their videos loop by default.

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also add this to a user setting (whether to auto-loop videos or not) and then just reference the store here.

@alextran1502 alextran1502 merged commit 1d427d0 into immich-app:main Apr 10, 2024
23 of 25 checks passed
@lukashass lukashass deleted the video-thumbnail-loop branch April 10, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants