fix(server): link motion photo with existing video asset #8724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldietzler
approved these changes
Apr 11, 2024
| @@ -439,7 +439,7 @@ describe(MetadataService.name, () => { | |||
| }); | |||
| cryptoRepository.hashSha1.mockReturnValue(randomBytes(512)); | |||
| assetMock.getByChecksum.mockResolvedValue(null); | |||
| assetMock.create.mockResolvedValue(assetStub.livePhotoMotionAsset); | |||
| assetMock.create.mockImplementation((asset) => Promise.resolve({ ...assetStub.livePhotoMotionAsset, ...asset })); | |||
There was a problem hiding this comment.
AFAICT the create function is only called once, correct? Why can't we use mockResolvedValue then, given that we already know which asset we pass in.
jrasm91
reviewed
Apr 11, 2024
|
|
||
| if (asset.livePhotoVideoId !== motionAsset.id) { |
There was a problem hiding this comment.
does this whole method run even when an asset is already linked?
There was a problem hiding this comment.
Ah, nevermind. This is for the case we had awhile ago with corrupt extraction.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8508, closes #8503.
Originally part of #8512.
Links existing video asset with motion photo if their checksum matches.
Should NOT be merged until #8719 is merged to prevent cross library linking.