feat(web): support 360 video (equirectangular) #8762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truongsinh
changed the title
|
Hello, is there a sample video that you can attach to this PR? |
Yes I can provide sample file. Where in the codebase should I place the file? |
|
Anyway, meanwhile I can attach it here: output1.mp4 |
truongsinh
changed the title
|
Hello, can you help fix the failed web test? Thanks |
|
done, and thank you for resolving conflicts earlier. |
…' of github.com:immich-app/immich into 360video
alextran1502
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #5130 and #5414 .
Microservice already does a good job of extracting
projectionTypetag. This PR only make sure to use the correct (panorama) viewer when the video has EquirectangularAdapter projectionType. Unlike 360 image, 360 video requires navbar and progress bar.