fix(server): skip invisible assets for thumbnail generation and ml #8891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying immich with
|
| Latest commit: |
9a2274b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d3e11f22.immich.pages.dev |
| Branch Preview URL: | https://fix-server-live-photo-thumbn.immich.pages.dev |
danieldietzler
approved these changes
Apr 18, 2024
jrasm91
approved these changes
Apr 19, 2024
mertalev
force-pushed
the
fix/server-live-photo-thumbnails
branch
from
3b1c8d0
to
9a2274b
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently process live photos through our image and machine learning pipelines, but this is both unnecessary and causes issues of its own (e.g. #8597 where facial recognition is matching live photos). This PR adds checks on these jobs to skip them if
isVisibleis false.Fixes #8597