fix(web): search people #8955
Merged
fix(web): search people #8955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying immich with
|
| Latest commit: |
e16bfcd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://89565f1f.immich.pages.dev |
| Branch Preview URL: | https://fix-search-people.immich.pages.dev |
3 tasks
martabal
force-pushed
the
fix/search-people
branch
from
9f71ed4
to
4b46873
Compare
|
Any idea why I'm losing focus whenever I type a single character? Screen.Recording.2024-04-22.at.20.44.23.mov |
It was fixed on |
Co-authored-by: Daniel Dietzler <36593685+danieldietzler@users.noreply.github.com>
danieldietzler
force-pushed
the
fix/search-people
branch
from
4b46873
to
e16bfcd
Compare
|
That was it, thank you Alex! However it still loses focus when the search field becomes empty. Is that intentional? |
Probably not, I think it is a "bug" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #8951.
Show people searched with the
searchPersonAPI instead of relying on people returned by thegetAllPeopleAPI.Screenshots