refactor(server): session interface types #8977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying immich with
|
| Latest commit: |
65ef3a4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4118d772.immich.pages.dev |
| Branch Preview URL: | https://refactor-session-interface-t.immich.pages.dev |
bo0tzz
approved these changes
Apr 20, 2024
|
Definitely, but not today :-) |
danieldietzler
approved these changes
Apr 20, 2024
| @@ -2,10 +2,12 @@ import { SessionEntity } from 'src/entities/session.entity'; | |||
|
|
|||
| export const ISessionRepository = 'ISessionRepository'; | |||
|
|
|||
| type E = SessionEntity; | |||
There was a problem hiding this comment.
I was considering making all interfaces implement a BaseInterface that has the correct typings for create, update, delete, and get. It would be something like BaseInterface<E> and then the methods would indeed reference E.
jrasm91
force-pushed
the
refactor/session-interface-types
branch
from
9631dcf
to
65ef3a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.