Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(server, web, mobile): Change wording of memory titles #9025

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

rawcomposition
Copy link
Contributor

On the memory cards, I think the [n] years since... titles should say [n] years ago.

If the caption was above the image, it might make more sense. It would read more like:

15 years since...[this image of me eating pizza]

But because it's a caption over top of the image and positioned at the bottom, your eye goes to the image first, then the caption, and hence it reads more like:

[this image of me eating pizza]. 15 years since...

Which grammatically doesn't make much sense.

I wish I knew enough about Dart to refactor the titles so they use i18n instead of just showing the title value from the JSON response, but I'm completely lost in Dart, unfortunately!

@alextran1502 alextran1502 enabled auto-merge (squash) April 23, 2024 15:07
@alextran1502 alextran1502 merged commit 661540c into immich-app:main Apr 23, 2024
22 of 23 checks passed
@rawcomposition rawcomposition deleted the refactor/memory-titles branch April 23, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants