refactor(server, web, mobile): Change wording of memory titles #9025
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the memory cards, I think the
[n] years since...
titles should say[n] years ago
.If the caption was above the image, it might make more sense. It would read more like:
But because it's a caption over top of the image and positioned at the bottom, your eye goes to the image first, then the caption, and hence it reads more like:
Which grammatically doesn't make much sense.
I wish I knew enough about Dart to refactor the titles so they use i18n instead of just showing the
title
value from the JSON response, but I'm completely lost in Dart, unfortunately!