-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): --ignore
getting ignored
#9071
Conversation
Deploying immich with
|
Latest commit: |
0ece226
|
Status: | ✅ Deploy successful! |
Preview URL: | https://2e9f870f.immich.pages.dev |
Branch Preview URL: | https://fix-cli-ignore.immich.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an e2e test for this?
It turns out there was more than one issue here:
|
immich upload -n -i /Recently/ -r /media/Vault/Apple\ iCloud\ Photos/7/iCloud\ Photos\ Part\ 68\ of\ 68/ Expected behavior would be 0 assets as the only 2 things are in a folder titled. Recently Deleted |
The CLI does not randomly ignore folders because of their name. And IMO that's a good thing, in case that's what you're referring to @TransRapid |
No, the issue is the |
Can you confirm that you're actually using a CLI build that has the fixes in this PR? It isn't in the latest CLI release. |
Do we know when the fix will be released? For me I did a script with a "find" workaround to avoid the unwanted directory. |
Description
The internal typing for this flag expects
exclusionPatterns
, so it will always consider it to beundefined
.How Has This Been Tested?
Tested that it actually ignores the pattern specified in the command.