fix(web): the selected tab on the sidebar was not always shown as selected #9084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ected. Used regex to get necessary portion for comparison
alextran1502
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The sidebar sometimes did not show that the current tab was selected. This is because the check was comparing the current route and then list of route Ids. When certain tabs were selected, like the photos tab, the
$page.route.idwould return/(user)/photos/[[assetId=id]]while the check was looking for/(user)/photos. Regex was used to check for just the first portion ie./(user)/[anything]as well as/admin/[anything]. The regex has an or for an empty array to avoid returning null if there are no matches.The colour when hovered and selected was also changed from
bg-immich-primary-25tobg-immich-primary-10as a darker hover is not needed when on the current page, just seems redundant and doesn't look as good.How has this been tested
I ran the
npm run check:alland tested both the user and admin page within the browser.