chore(server): remove unused endpoint/service/interface in asset-v1 #9086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ected. Used regex to get necessary portion for comparison
Deploying immich with
|
| Latest commit: |
f91def8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7f4e714d.immich.pages.dev |
| Branch Preview URL: | https://web-remove-unused-endpoint.immich.pages.dev |
danieldietzler
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Is the app currently still using those? If yes we may want to wait a release or two, right?
There was a problem hiding this comment.
No, we just need to merge #9085 first
There was a problem hiding this comment.
So if mobile still depends on it next release will be a breaking change, right? Why not wait a few releases then until we remove the endpoint?
There was a problem hiding this comment.
Mobile doesn't use this anymore, it was part of the other pr where I removed unused code.
jrasm91
approved these changes
Apr 26, 2024
danieldietzler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unused endpoint in
asset-v1