feat(web,a11y): form and search filter accessibility #9087
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move checkboxes / radio buttons into components
Created components to reduce duplicated code, build in accessibility by default, and provide a consistent user experience anywhere that checkboxes are used.
All usages of
<input type="checkbox" />
were updated to use this new component.Add labels to the context/file name search filters
The radio button labeling wasn't working with the screen reader. There are options to make this work using
aria-labelledby
, but I preferred adding labels to both the radio button and input fields for clarity. I'm open to thoughts or opinions on this!Other accessibility changes
tabindex="-1"
to the search filter container, to prevent Firefox from thinking that it is focusableScreenshots
Expand for screenshots
Desktop: labels for context/file name search
Mobile: labels for context/file name search
Focused checkbox
How Has This Been Tested?
Navigate through the search filters and affected checkbox modals to verify they work as expected.
Checkboxes changed:
Checklist:
AlbumUserAddDto
andalbumUsers
that are unrelated to my change