fix(cli): dry run being inaccurate #9088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The dry run always returns an empty list for the list of new assets, meaning it will always report that it would create 0 new albums. This PR changes this to return a list of dummy assets instead for accurate reporting.
It also adds a bunch of e2e tests for dry runs since we seem to not test this flag at all right now.
Lastly, it makes dry runs incompatible with the
--skip-hashflag since duplicates can't be accurately handled in this case.Fixes #8966
How Has This Been Tested?
Tested that the dry run lines up with the real run with a number of different commands.