Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lifecycle metadata #9103

Merged
merged 1 commit into from
Apr 29, 2024
Merged

chore: lifecycle metadata #9103

merged 1 commit into from
Apr 29, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Apr 27, 2024

Attempt to track endpoint and dto metadata - when it was added and deprecated

Usage:

// add a new endpoint
@EndpointLifecycle({ addedAt: 'v1.100.0' })

// deprecate an endpoint
@EndpointLifecycle({ addedAt: '1.100.0', deprecatedAt: '1.103.0' }

// add a new property
@PropertyLifecycle({ addedAt: 'v1.100.0' })

// deprecate a property
@PropertyLifecycle({ addedAt: '1.100.0', deprecatedAt: '1.103.0' }

open-api-spec.json

"x-immich-lifecycle": {
  "addedAt": "1.100.0"
  "deprecatedAt": "1.103.0"
}

server npm command for a report

npm run lifecycle

Changes in NEXT_RELEASE
---------------------
- Deprecated GET /user/info/{id} (getUserById)
- Deprecated PartnerResponseDto.quotaSizeInBytes
- Deprecated UserResponseDto.quotaSizeInBytes

Changes in v1.102.0
---------------------
- Deprecated AddUsersDto.sharedUserIds
- Deprecated AlbumResponseDto.sharedUsers

Changes in 1.100.0
---------------------
- Deprecated GET /assets (searchAssets)

Changes in v1.100.0
---------------------
- Added      GET /user/info/{id} (getUserById)
- Deprecated MemoryLaneResponseDto.title
- Deprecated MetadataSearchDto.resizePath
- Deprecated MetadataSearchDto.webpPath

Changes in v1.90.0
---------------------
- Deprecated GET /search (search)

Changes in v1.80.0
---------------------
- Added      GET /search (search)

TODO:

  • Update pump-version.sh to replace NEXT_RELEASE and regenerate the sdks (future PR)

Copy link

cloudflare-pages bot commented Apr 27, 2024

Deploying immich with  Cloudflare Pages  Cloudflare Pages

Latest commit: 195446b
Status:⚡️  Build in progress...

View logs

@jrasm91 jrasm91 marked this pull request as ready for review April 28, 2024 00:19
@jrasm91
Copy link
Contributor Author

jrasm91 commented Apr 28, 2024

Not sure how all the automation will work, but there are several endpoints that need to be deprecated. I think we should maybe just merge this as is so we at least have some information to use moving forward. We can always figure out and add automation in the future.

server/src/utils/lifecycle.ts Outdated Show resolved Hide resolved
server/src/utils/lifecycle.ts Outdated Show resolved Hide resolved
server/src/utils/lifecycle.ts Outdated Show resolved Hide resolved
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

server/src/decorators.ts Outdated Show resolved Hide resolved
@jrasm91 jrasm91 enabled auto-merge (squash) April 29, 2024 13:44
@jrasm91 jrasm91 merged commit 59caf1f into main Apr 29, 2024
22 of 23 checks passed
@jrasm91 jrasm91 deleted the dev/lifecycle-metadata branch April 29, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants