Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(server): remove old asset search #9104

Merged
merged 2 commits into from
Apr 27, 2024
Merged

chore(server): remove old asset search #9104

merged 2 commits into from
Apr 27, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Apr 27, 2024

No description provided.

@jrasm91 jrasm91 requested a review from mertalev April 27, 2024 01:23
@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Apr 27, 2024 •
edited
Loading

Deploying immich with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4479f70
Status: ✅  Deploy successful!
Preview URL: https://2e382db2.immich.pages.dev
Branch Preview URL: https://chore-remove-asset-search.immich.pages.dev

View logs

mertalev
mertalev approved these changes Apr 27, 2024
View reviewed changes
Copy link
Contributor

@mertalev mertalev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can also remove the search method in the search service and the searchMetadata method in the asset repo.

danieldietzler
danieldietzler approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jrasm91 jrasm91 enabled auto-merge (squash) April 27, 2024 12:54
@jrasm91 jrasm91 merged commit 5a49de5 into main Apr 27, 2024
23 checks passed
@jrasm91 jrasm91 deleted the chore/remove-asset-search branch April 27, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldietzler danieldietzler danieldietzler approved these changes

@mertalev mertalev mertalev approved these changes

Assignees
No one assigned
Labels
🗄️server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrasm91 @danieldietzler @mertalev