fix(server): asset count on meta tag of shared links #9107
Conversation
| @@ -185,7 +185,7 @@ export class SharedLinkService { | |||
|
|
|||
| const sharedLink = await this.findOrFail(auth.sharedLink.userId, auth.sharedLink.id); | |||
| const assetId = sharedLink.album?.albumThumbnailAssetId || sharedLink.assets[0]?.id; | |||
| const assetCount = sharedLink.assets.length ?? sharedLink.album?.assets.length ?? 0; | |||
| const assetCount = sharedLink.assets.length || sharedLink.album?.assets.length || 0; | |||
There was a problem hiding this comment.
When share link is a whole album, sharedLink.assets.length is 0 and sharedLink.album?.assets.length is the real asset count. But 0 ?? 10 ?? 0 === 0.
There was a problem hiding this comment.
@danieldietzler see another reason why || is better than ??. Just causes headaches most of the time imo.
There was a problem hiding this comment.
Haha! I think there are valid scenarios in which you specifically don't want || but yeah, by default I see your point
There was a problem hiding this comment.
Good catch. We should probably add an e2e test for this. Is that something you want to take a look at? Essentially, make an http request to /share/<key> and make sure the resulting html returns the correct meta tags. We could add this in e2e/src/api/specs/shared-link.e2e-spec.ts.
sure, I'll add one |
Fixed #8605