fix(server): untracked thumbnail and preview images #9126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ability to choose the format means that it's no longer enough to overwrite a preview or thumbnail asset: in cases where the old path differs from the new, the old file will be left behind. This PR explicitly checks for this case and deletes the old path.
There is a bit of duplication here since the check is added separately for previews and thumbnails. I did this to make the behavior more transparent: the
generateThumbnailhelper should only generate an image, not have a side effect of deleting another file.Fixes #8981
How Has This Been Tested?
Tested by checking that there are only a few untracked assets in the repair page, changing the target thumbnail and preview formats, re-running thumbnail generation and confirming there's no explosion of untracked files after thumbnail generation is complete.