Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mobile): services and providers #9232

Merged
merged 2 commits into from
May 2, 2024

Conversation

alextran1502
Copy link
Contributor

@alextran1502 alextran1502 commented May 2, 2024

  • Move all services to services directory at root level of lib
  • Move all providers to providers directory at root level of lib, keep some providers grouped with logical level since there are many providers within that group

image

  • Removed unused providers

Copy link

cloudflare-pages bot commented May 2, 2024

Deploying immich with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9d507df
Status: ✅  Deploy successful!
Preview URL: https://18533b64.immich.pages.dev
Branch Preview URL: https://mobile-refactor-services-pro.immich.pages.dev

View logs

@fyfrey
Copy link
Contributor

fyfrey commented May 2, 2024

Did you only move files around?
Could you summarize the changes made to discuss? Reviewing 200+ changed files... Takes too long :)

@alextran1502
Copy link
Contributor Author

@fyfrey Done, update the description

Copy link
Contributor

@fyfrey fyfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, I like the restructuring. All services in one folder is perfect!

@alextran1502 alextran1502 merged commit c125366 into main May 2, 2024
24 of 25 checks passed
@alextran1502 alextran1502 deleted the mobile/refactor-services-providers branch May 2, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants