feat(server): read-write external assets #9235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 3, 2024
Deploying immich with
|
| Latest commit: |
05ee1bf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f8557e62.immich.pages.dev |
| Branch Preview URL: | https://feat-rw-external-assets.immich.pages.dev |
benmccann
reviewed
May 3, 2024
| @@ -106,9 +106,6 @@ export class AssetEntity { | |||
| @Column({ type: 'boolean', default: false }) | |||
| isExternal!: boolean; | |||
There was a problem hiding this comment.
I noticed you removed this from the open API definition. Do we still need it here? If you end up making your change to have null libraryId indicate an upload library then this becomes redundant because you can just check if there's a library id present or not
|
Thank you so much for all the work you've done on the external libraries, it's the feature I need most at the moment and it's finally here! |
danieldietzler
approved these changes
May 3, 2024
| @@ -113,6 +113,7 @@ export const DummyValue = { | |||
| PAGINATION: { take: 10, skip: 0 }, | |||
| EMAIL: 'user@immich.app', | |||
| STRING: 'abcdefghi', | |||
| NUMBER: 50, | |||
There was a problem hiding this comment.
Suggested change
| NUMBER: 50, | |
| NUMBER: 42, |
Missed opportunity ;)
| @@ -170,7 +170,7 @@ export class StorageTemplateService { | |||
| } | |||
|
|
|||
| async moveAsset(asset: AssetEntity, metadata: MoveAssetMetadata) { | |||
| if (asset.isReadOnly || asset.isExternal || StorageCore.isAndroidMotionPath(asset.originalPath)) { | |||
| if (asset.isExternal || StorageCore.isAndroidMotionPath(asset.originalPath)) { | |||
| // External assets are not affected by storage template | |||
| // TODO: shouldn't this only apply to external assets? | |||
There was a problem hiding this comment.
Suggested change
| // TODO: shouldn't this only apply to external assets? |
?
There was a problem hiding this comment.
yeah, yeah need to write something explaining why android motion path ones are skipped as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change: external libraries and associated assets are no longer read only and can now be deleted.
After a bunch of back and forth within the developer team, this is the final implementation we landed on:
isReadOnlycolumnisExternalandisReadOnlyasset response propertiesSupersedes: #9188, #8992, #8943
Closes: #5449
Reference: #8438