fix(web): stream 360 video instead of fetching entire video #9279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bo0tzz
approved these changes
May 6, 2024
The existing non-panoramic video player already uses this approach. (Hence why large regular videos do not have the same issue playing.) |
jrasm91
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Immich web client fetches entire 360 videos before beginning to play them. This causes long/large 360 videos to be unplayable as the request to fetch a very large (tested with a > 30 GB video) 360 video eventually fails.
This PR fixes that issue by passing the URL to the video asset to the Photo Sphere Viewer module instead of fetching the entire video and converting it to a Blob that is then passed to the aforementioned module.