Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server): remove unused deps #9334

Merged
merged 1 commit into from
May 8, 2024
Merged

chore(server): remove unused deps #9334

merged 1 commit into from
May 8, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented May 8, 2024

  • remove packages we don't use directly
  • add a missing @ApiProperty decorator

@@ -38,6 +38,7 @@ class AlbumUserCreateDto {
userId!: string;

@IsEnum(AlbumUserRole)
@ApiProperty({ enum: AlbumUserRole, enumName: 'AlbumUserRole' })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't necessary but you still prefer having it there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is necessary actually. Otherwise it defaults to strings instead of a named enum.

@jrasm91 jrasm91 merged commit 8e9895d into main May 8, 2024
23 of 24 checks passed
@jrasm91 jrasm91 deleted the chore/unused-deps branch May 8, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants