fix(web): multiple fixes for people #9343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying immich with
|
| Latest commit: |
ec36a98
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8c5e20f1.immich.pages.dev |
| Branch Preview URL: | https://fix-multiple-fix-for-people.immich.pages.dev |
martabal
force-pushed
the
fix/multiple-fix-for-people
branch
2 times, most recently
from
97e1184
to
0e5e684
Compare
|
@martabal wow you're fast :) |
martabal
force-pushed
the
fix/multiple-fix-for-people
branch
2 times, most recently
from
79987a1
to
80530f1
Compare
martabal
force-pushed
the
fix/multiple-fix-for-people
branch
from
80530f1
to
b671d61
Compare
martabal
force-pushed
the
fix/multiple-fix-for-people
branch
from
b671d61
to
ed31af1
Compare
alextran1502
reviewed
May 9, 2024
| @@ -6,8 +6,8 @@ | |||
|
|
|||
| export let screenHeight: number; | |||
| export let people: PersonResponseDto[]; | |||
| export let peopleCopy: PersonResponseDto[]; | |||
| export let unselectedPeople: PersonResponseDto[]; | |||
| export let peopleToNotShow: PersonResponseDto[]; | |||
There was a problem hiding this comment.
Is this peopleToNotShow are filtered out people from the search query?
There was a problem hiding this comment.
Yep, on the unmerge and merge modals, there's people you don't to appear in the list, like the people already selected, the person to merge, to un-merge ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes multiple fixes for the webUI related to the people feature: