Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server): less rigid transcoding tests #9401

Merged
merged 2 commits into from
May 12, 2024

Conversation

mertalev
Copy link
Contributor

@mertalev mertalev commented May 12, 2024

Description

The transcoding tests expect not only an exact set of options, but a specific order of these options. This PR uses arrayContaining to focus on the relevant aspect of a given test, improving clarity of intent and reducing the number of false positives when irrelevant changes are made. It tries to strike a balance of testing each codec with a broader set of flags once and testing more specific aspects with only one or two flags elsewhere.

@mertalev mertalev merged commit f667c95 into main May 12, 2024
24 of 25 checks passed
@mertalev mertalev deleted the chore/less-rigid-media-tests branch May 12, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants