Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): icon consistency and improvements #9403

Merged

Conversation

NicholasFlamy
Copy link
Contributor

Add change from outline to regular icon in sidebar when page selected to more of the icons (previously only applied to Photos, Sharing, and Favorites). Also change Favorites to single heart consistent with mobile app. (I can change anything if y'all would like.)

@NicholasFlamy NicholasFlamy marked this pull request as ready for review May 12, 2024 04:04
@alextran1502
Copy link
Contributor

Can you post before and after screenshot?

@NicholasFlamy
Copy link
Contributor Author

NicholasFlamy commented May 12, 2024

Yes.
Before:



After:

@alextran1502 alextran1502 changed the title Icon consistency and improvements chore(web): icon consistency and improvements May 12, 2024
@alextran1502 alextran1502 merged commit a97e0ca into immich-app:main May 12, 2024
22 of 23 checks passed
@jrasm91
Copy link
Contributor

jrasm91 commented May 12, 2024

I think favorites (plural) should be a double icon, similar to photos. In fact, it was specifically changed to this originally. The mobile app probably just needs to be updated to match it.

@NicholasFlamy
Copy link
Contributor Author

I think favorites (plural) should be a double icon, similar to photos. In fact, it was specifically changed to this originally. The mobile app probably just needs to be updated to match it.

I was really curious about this. I had a feeling it might have been on purpose. If y'all agree on it I'll make the change on the web and the mobile app. I do think that with the style of the button for Favorites on the mobile app a single heart looks better but for the web it doesn't matter to me as much, though on small screens with the sidebar closed I think it looks better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants