fix(server): addAssets and removeAssets handle duplicate assetIds

[eric-barch]

Fixes #9368, where calling addAssets with duplicate ids results in an internal server error.

This fix leverages the existingAssetIds Set already included in addAssets, but I could see the argument that we should keep that reserved for assets that were in the database before calling addAssets. If you feel that way I can instead revise this to create a dedicated Set just for uniqueness within addAssets.

Input:

curl -X 'PUT' \
  'https://demo.immich.app/api/album/c757a1dc-afae-4cce-8f14-cf0adf5bea8e/assets' \
  -H 'accept: application/json' \
  -H 'Content-Type: application/json' \
  -d '{
  "ids": [
    "7f7e71ab-a630-449d-b7c1-c52fc8b44733",
    "7f7e71ab-a630-449d-b7c1-c52fc8b44733"
  ]
}'

Output:

Before:

{
  "message": "Failed to add assets to album",
  "error": "Internal Server Error",
  "statusCode": 500
}

After:

[
  {
    "id": "7f7e71ab-a630-449d-b7c1-c52fc8b44733",
    "success": true
  }, {
    "id": "7f7e71ab-a630-449d-b7c1-c52fc8b44733",
    "success": false,
    "error": "duplicate"
  }
]

For consistency, I also made the corresponding change in removeAssets. In my opinion the output from this change is more accurate/helpful, but let me know if you disagree.

Input:

curl -X 'DELETE' \
  'https://demo.immich.app/api/album/c757a1dc-afae-4cce-8f14-cf0adf5bea8e/assets' \
  -H 'accept: application/json' \
  -H 'Content-Type: application/json' \
  -d '{
  "ids": [
    "7f7e71ab-a630-449d-b7c1-c52fc8b44733",
    "7f7e71ab-a630-449d-b7c1-c52fc8b44733"
  ]
}'

Output:

Before:

[
  {
    "id": "7f7e71ab-a630-449d-b7c1-c52fc8b44733",
    "success": true
  }, {
    "id": "7f7e71ab-a630-449d-b7c1-c52fc8b44733",
    "success": true
  }
]

After:

[
  {
    "id": "7f7e71ab-a630-449d-b7c1-c52fc8b44733",
    "success": true
  }, {
    "id": "7f7e71ab-a630-449d-b7c1-c52fc8b44733",
    "success": false,
    "error": "not_found"
  }
]

[danieldietzler]

I'd say this is fine.

[jrasm91]

If you are up for it, can you add an e2e test for this? e2e/src/api/specs/album.e2e-spec.ts

[eric-barch]

Sure, no problem. I added two e2e tests, one for each endpoint I changed. I tried to keep the format as close as possible to the existing tests but let me know if you have any suggestions for improvement.

[jrasm91]

Looks perfect! Tyvm