fix(server): sync issue when delete remotes assets #9479
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9412
Fixes #9471
Expected interfaces
Before
![Screenshot from 2024-05-14 11-12-19](https://private-user-images.githubusercontent.com/27055614/330517409-424e3ec4-4413-426f-b59e-1314fa1b47bd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA4MjA1MDQsIm5iZiI6MTcyMDgyMDIwNCwicGF0aCI6Ii8yNzA1NTYxNC8zMzA1MTc0MDktNDI0ZTNlYzQtNDQxMy00MjZmLWI1OWUtMTMxNGZhMWI0N2JkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEyVDIxMzY0NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ3MzI5OWFiOGI1OGU5OTE2OGJmMDFjMzNhZWZhNWIwODFjMjdhYzZmOTk2YzAxNGZkOGRjYjk4ODlmZTMzNTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.pXNi8d9oJSx8u1vSFDS2TnbRtPCoQd6jibF0ZqCBHf8)
After
![Screenshot from 2024-05-14 11-12-31](https://private-user-images.githubusercontent.com/27055614/330517462-71a923ad-ed48-458f-bc7a-a45fff4084c0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA4MjA1MDQsIm5iZiI6MTcyMDgyMDIwNCwicGF0aCI6Ii8yNzA1NTYxNC8zMzA1MTc0NjItNzFhOTIzYWQtZWQ0OC00NThmLWJjN2EtYTQ1ZmZmNDA4NGMwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEyVDIxMzY0NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRjODlkMzk4MTI4MGExZjNlMDgyOWZhZGU4MWVhMmM3N2I5ZWUwYzJkMWZiZDNiZTY2Y2IxMzdjZDNjNmNjZWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.5MUTQtqCVR_lT5Pzu8sMxfM1tIF-EbWUlIvFJQ7xH9g)
cc @fyfrey FYI, you cannot trust typeORM in this case to correctly parse the select statement, I know it is weird 😢