Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: port env #9559

Merged
merged 1 commit into from
May 17, 2024
Merged

refactor!: port env #9559

merged 1 commit into from
May 17, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented May 17, 2024

  • Use IMMICH_PORT and IMMICH_HOST everywhere.

const app = await NestFactory.create(MicroservicesModule, { bufferLogs: true });
const logger = await app.resolve(ILoggerRepository);
logger.setAppName('ImmichMicroservices');
logger.setContext('ImmichMicroservices');
app.useLogger(logger);
app.useWebSocketAdapter(new WebSocketAdapter(app));

await (host ? app.listen(port, host) : app.listen(port));
await app.listen(0);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't actually use this port, so just pick a random one. (TODO: remove listening entirely in the future)

machine-learning/start.sh Outdated Show resolved Hide resolved
Copy link

cloudflare-pages bot commented May 17, 2024

Deploying immich with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7096145
Status: ✅  Deploy successful!
Preview URL: https://41b3cd1a.immich.pages.dev
Branch Preview URL: https://refactor-port-env.immich.pages.dev

View logs

@jrasm91 jrasm91 dismissed mertalev’s stale review May 17, 2024 16:36

Host is first now

@jrasm91 jrasm91 merged commit d614188 into main May 17, 2024
23 checks passed
@jrasm91 jrasm91 deleted the refactor/port-env branch May 17, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants