Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(server): version logic #9615

Merged
merged 2 commits into from
May 21, 2024
Merged

refactor(server): version logic #9615

merged 2 commits into from
May 21, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented May 20, 2024

Use semver library for version compatibility checking and parsing.

Copy link

cloudflare-pages bot commented May 20, 2024

Deploying immich with  Cloudflare Pages  Cloudflare Pages

Latest commit: d54650d
Status: ✅  Deploy successful!
Preview URL: https://df682db2.immich.pages.dev
Branch Preview URL: https://refactor-semver.immich.pages.dev

View logs

Copy link
Contributor

@mertalev mertalev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good (and necessary) change, but I think the reduced test coverage and messy database service init should be resolved.

server/src/services/database.service.spec.ts Show resolved Hide resolved
server/src/services/database.service.ts Show resolved Hide resolved
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jrasm91 jrasm91 force-pushed the refactor/semver branch 2 times, most recently from 9972968 to 63bacc0 Compare May 21, 2024 00:07
@jrasm91 jrasm91 merged commit 1df7be8 into main May 21, 2024
23 checks passed
@jrasm91 jrasm91 deleted the refactor/semver branch May 21, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants