-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: deprecate /server-info and replace with /server-info/storage #9645
Conversation
Deploying immich with Cloudflare Pages
|
@@ -4337,14 +4337,16 @@ | |||
}, | |||
"/server-info": { | |||
"get": { | |||
"deprecated": true, | |||
"description": "This property was deprecated in v1.106.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh this might be a little bug that it should say endpoint instead of property. looks like it uses the same description for both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, fixing this is actually not super-trivial. I think I'd prefer a neutral name that works for both properties and endpoints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the tests this looks good ;)
I'll fix those in the morning, brain was mush by the time this was done 🤣 |
40c4fb3
to
14849a9
Compare
/server-info root endpoint was used for storage info only, moving this to a more sensible place