Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): set album description textarea height correctly #9880

Merged
merged 10 commits into from
Jun 1, 2024

Conversation

Snowknight26
Copy link
Contributor

Fixes #9879.

Changes:

  • Applied the same approach fix(web): detail panel asset description #9765 implemented to the album description textarea
  • Deduplicated the detail panel description and the album description sections into a single component
  • Set the textarea value correctly since value is not a valid textarea property

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests for this functionality?

@Snowknight26
Copy link
Contributor Author

What kind of tests are you looking for? Unit? Integration/e2e test?

I couldn't find any contributing guidelines on tests so I'm not sure what's expected, but will do my best to add what's needed.

If it matters, the existing e2e/src/web/specs/asset-viewer/detail-panel.e2e-spec.ts regression tests at least some changes to detail-panel.svelte (and in turn, detail-panel-description.svelte).

@jrasm91
Copy link
Contributor

jrasm91 commented May 31, 2024

There have just been a lot of bugs with the description field not working properly. It should change when you navigate to the next asset and it should resize as well. A unit test would probably be fine. I think there are a few examples of this.

@Snowknight26
Copy link
Contributor Author

Admittedly I don't know how to test the resizing functionality (and admittedly, should resizing be tested, or just that the auto-grow function is called?) or navigating.. but I wonder if what's been added is adequate.

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jrasm91 jrasm91 merged commit 21718cc into immich-app:main Jun 1, 2024
22 checks passed
@Snowknight26 Snowknight26 deleted the fix/description-height branch June 1, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web: Album description grows too tall when navigating to an album via an asset
4 participants