feat(web): add cover images to individual shares #9988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Snowknight26
commented
Jun 5, 2024
•
Snowknight26
commented
…-covers-to-individual-shares # Conflicts: # web/src/lib/components/album-page/album-cover.svelte # web/src/lib/components/sharedlinks-page/shared-link-card.svelte
web/src/lib/components/album-page/__tests__/album-cover.spec.ts
Outdated
Show resolved
Hide resolved
web/src/lib/components/sharedlinks-page/covers/__tests__/no-cover.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
IMO this should be in the asset cover and used if src is undefined. Having an extra component in that case feels a bit weird to me.
There was a problem hiding this comment.
One of the reasons I went for this approach was to deduplicate its usage. Since the 'undefined' image was referenced in two places, now only one component would have to be updated to ensure it's consistent in both places it's referenced.
I agree it's a little odd to have a component that's nothing but a wrapper for an <enhanced:img> tag.
web/src/lib/i18n/en-US.json
Outdated
| @@ -362,7 +362,6 @@ | |||
| "editor": "Editor", | |||
| "email": "Email", | |||
| "empty": "Empty", | |||
| "empty_album": "Empty Album", | |||
There was a problem hiding this comment.
It was changed to unnamed_share, but if we want the key preserved I can change the string only.
…-covers-to-individual-shares
web/src/lib/components/album-page/__tests__/album-cover.spec.ts
Outdated
Show resolved
Hide resolved
web/src/lib/components/album-page/__tests__/album-cover.spec.ts
Outdated
Show resolved
Hide resolved
…-covers-to-individual-shares # Conflicts: # web/src/lib/i18n/en.json
michelheusschen
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.