process log pipe fixed but need to kill extra loggers

daemon.go

@@ -59,8 +59,6 @@ func (d *Daemon) Run(p Process) (*process, error) {
 	}
 
 	return process, nil
-	// control process loop
-	//go d.control(process)
 }
 
 // WritePid write pid to file

daemon_test.go

@@ -1,6 +1,7 @@
 package immortal
 
 import (
+	"fmt"
 	"io/ioutil"
 	"os"
 	"os/signal"
@@ -113,6 +114,15 @@ func TestHelperProcessSignalsUDOT(*testing.T) {
 		os.Exit(1)
 	case <-time.After(10 * time.Second):
 		os.Exit(0)
+	default:
+		for i := 1; i < 10; i++ {
+			if i%3 == 0 {
+				fmt.Fprintf(os.Stderr, "STDERR i: %d\n", i)
+			} else {
+				fmt.Printf("STDOUT i: %d\n", i)
+			}
+			time.Sleep(time.Second)
+		}
 	}
 }
 
@@ -136,6 +146,10 @@ func TestSignalsUDOT(t *testing.T) {
 			Parent: filepath.Join(parentDir, "parent.pid"),
 			Child:  filepath.Join(parentDir, "child.pid"),
 		},
+		//Log: Log{
+		//File: "/tmp/test.log",
+		//},
+		Logger: "logger -t test",
 	}
 	d, err := New(cfg)
 	if err != nil {

logger.go

@@ -2,13 +2,14 @@ package immortal
 
 import (
 	"bufio"
-	"github.com/immortal/logrotate"
-	"github.com/immortal/multiwriter"
 	"io"
 	"log"
 	"os/exec"
 	"strings"
 	"time"
+
+	"github.com/immortal/logrotate"
+	"github.com/immortal/multiwriter"
 )
 
 type Logger interface {
@@ -84,14 +85,14 @@ func NewLogger(cfg *Config) *log.Logger {
 	return nil
 }
 
-func (self *LogWriter) StdHandler(input io.ReadCloser) {
+func (l *LogWriter) StdHandler(input io.ReadCloser) {
 	in := bufio.NewScanner(input)
 	for in.Scan() {
-		self.logger.Print(in.Text())
+		l.logger.Print(in.Text())
 	}
 	input.Close()
 }
 
-func (self *LogWriter) IsLogging() bool {
-	return self.logger != nil
+func (l *LogWriter) IsLogging() bool {
+	return l.logger != nil
 }

process.go

@@ -76,9 +76,6 @@ func (p *process) Start() (*process, error) {
 		w *io.PipeWriter
 	)
 	if p.Logger.IsLogging() {
-		defer func() {
-			w.Close()
-		}()
 		r, w = io.Pipe()
 		p.cmd.Stdout = w
 		p.cmd.Stderr = w
@@ -96,11 +93,14 @@ func (p *process) Start() (*process, error) {
 	p.sTime = time.Now()
 
 	p.errch = make(chan error)
-	go func() {
+	go func(w *io.PipeWriter) {
 		err := p.cmd.Wait()
 		p.eTime = time.Now()
+		if w != nil {
+			w.Close()
+		}
 		p.errch <- err
-	}()
+	}(w)
 	return p, nil
 }