fix: add encoding argument on accounts/:name/sign #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cypherhat, Do I have to manually update the doc or is there a documentation generator ? If it's manual, tell me and I'll add the extra info. |
|
The doc is not generated. You will need to add the doc to this PR. Thanks so much. |
|
@cypherhat, can you wait before merging ? I have a final test to do this evening if I get the time. I'll ping you when it seems all fine |
|
Absolutely. Ping me - I should be online. |
|
Hi @cypherhat, all seems fine, merge whenever you want |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an
encodingargument on themount-path/accounts/:name/signcall. This argument was required in order to have a properkeccak256hash result of an hex encoded payload.