Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Immutable.fromJS: Detect cycles (RangeError: Maximum call stack size exceeded) #653

Closed
gasi opened this issue Oct 9, 2015 · 2 comments
Closed

Immutable.fromJS: Detect cycles (RangeError: Maximum call stack size exceeded) #653

gasi opened this issue Oct 9, 2015 · 2 comments

Comments

@gasi
Copy link
Contributor

gasi commented Oct 9, 2015

When trying to convert circular data structures using Immutable.fromJS, it currently throws RangeError: Maximum call stack size exceeded. Instead of this, could fromJS follow the semantics of JSON.stringify and throw a more meaningful error, similar to TypeError: Converting circular structure to JSON?

Pardon if this is a duplicate, but I searched the existing issues for this and couldn’t find it.

Please let me know if you need any more details and thanks for building Immutable.js 😄

Repro: https://jsbin.com/kupavixuhe/edit?js,console
@gscottolson
Copy link

👍

@paramsingh88
Copy link

Any solution ??

leebyron added a commit that referenced this issue Mar 8, 2017
@leebyron
Throw error when converting a circular structure via fromJS
167bc17 
Fixes #653
@leebyron leebyron mentioned this issue Mar 8, 2017
Merged
leebyron added a commit that referenced this issue Mar 8, 2017
@leebyron
Throw error when converting a circular structure via fromJS
86abdf9 
Fixes #653
leebyron added a commit that referenced this issue Mar 8, 2017
@leebyron
Throw error when converting a circular structure via fromJS (#1106)
7da5cbd 
Fixes #653
@marvinhagemeister marvinhagemeister mentioned this issue Sep 12, 2020
Closed
@mcclure mcclure mentioned this issue Sep 12, 2020
Closed
This was referenced Oct 16, 2020
Open
Open
Open
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gasi @gscottolson @paramsingh88