Adds back delete() and clear() to Record #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds back the delete() and clear() methods to Record instances that set values back to the default values, in the process improving the equals() and hashCode() implementations.
leebyron
referenced
this pull request
Mar 13, 2017
* RFC: Refactor Record. No longer a Collection. Faster guts. This is a breaking change refactor of Record which no longer extends a collection type and therefore does not inherit sequence methods - which was a constant source of confusion and breakage. It also refactors the internals to no longer rely on a Map, but instead a fixed size List which should result in dramatically faster performance. This is also a breaking change as `delete()` (aka `remove()`) and `clear()` are no longer available - previously these methods reverted values to their default value, now that can be done with `set(k, undefined)`. This adds a predicate function `isRecord()` and also minorly refactors related functionality such as `Seq()` constructors. Fixes #505 Fixes #286 * Add perf test
|
Can we add |
errendir
added a commit
to errendir/immutable-js
that referenced
this pull request
Aug 24, 2017
…ings * facebook/master: (146 commits) Add descriptive titles (immutable-js#1244) expect setting Record property to throw (immutable-js#1194) Change the has method of Record to be a type guard (immutable-js#1232) Add back deleteIn() and removeIn() to Record (immutable-js#1179) Fix typo: change 'hiearchy' to 'hierarchy' (immutable-js#1222) Fix typo in OrderedMap#toKeyedSeq (immutable-js#1177) Fixes missing size property in flow types. (immutable-js#1173) Fix size of count() after filtering or flattening (immutable-js#1171) Support typescript strictNullChecks (immutable-js#1168) added links to header in docs immutable-js#356 (immutable-js#1164) Replace "an Collection" with "a Collection" everywhere (immutable-js#1163) Fix syntax highlighting and wrong variable names (immutable-js#1159) 4.0.0-rc.2 Adds back delete() and clear() to Record (immutable-js#1157) Improve filter typescript def to leverage predicate functions (immutable-js#1155) Improve type for reduce() (immutable-js#1156) Significant improvments to concat type definitions. (immutable-js#1153) Update README.md (immutable-js#1150) Add note for using with webpack Readme improvement pass ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds back the delete() and clear() methods to Record instances that set values back to the default values, in the process improving the equals() and hashCode() implementations.