Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test for power-of-2 hashes #1175

Closed
wants to merge 2 commits into from

Conversation

garrettm
Copy link

@garrettm garrettm commented Mar 15, 2017

It seems there is an issue with hash codes that are powers of 2 above 2**32--they cause infinite recursion.

Associated issue: #1176

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@garrettm garrettm changed the title Add failing test for hash collisions issue Add failing test for power-of-2 hashes Mar 15, 2017
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@kozlitinaelja
Copy link
Contributor

Thank you @garrettm for adding test! It can be merged when the fix will be ready =)

@leebyron
Copy link
Collaborator

Unfortunately this is just part of the contract of hashCode() that this test violates. hashCode() is expected to return a uint type, you could fix your test by instead using:

hashCode() {
  return (2 ** 32) | 0
}

@leebyron leebyron closed this Sep 29, 2017
@leebyron
Copy link
Collaborator

I just added this note to the documentation, and also included a fix to better handle this case!

@garrettm
Copy link
Author

Great, thank you @leebyron

leebyron added a commit that referenced this pull request Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants