Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contains fix for error during equals check on Record with undefined or null #1208

Merged
merged 1 commit into from
Sep 29, 2017
Merged

Contains fix for error during equals check on Record with undefined or null #1208

merged 1 commit into from
Sep 29, 2017

Conversation

anilreddykatta
Copy link
Contributor

@anilreddykatta anilreddykatta commented Apr 11, 2017 •
edited

  1. Added fix for checking null or unfined during equality checking
  2. Added tests for the check

Addresses #1202

@kozlitinaelja
Copy link
Contributor

Looks legit to me! Thank you @anilreddykatta for fixing it! @leebyron, is it ok if I merge it? =)

leebyron
leebyron reviewed Jun 1, 2017
View reviewed changes
Copy link
Collaborator

@leebyron leebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other && check should be part of the second clause to keep the first clause as fast as possible

@anilreddykatta
Copy link
Contributor Author

@leebyron Thanks for the feedback. I made changes accordingly @kozlitinaelja Can you please take a look and let me know of any concerns?

@leebyron leebyron merged commit 25b745d into immutable-js:master Sep 29, 2017
@leebyron
Copy link
Collaborator

Great fix! Sorry for the wait :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leebyron leebyron leebyron left review comments

Assignees
No one assigned
Labels
bug CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anilreddykatta @kozlitinaelja @leebyron @facebook-github-bot