revert export type of RecordInstance #1434
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice to meet you ! I always appreciate the wonderful module. The flow-type definition of
RecordFactory<T>
added from v4.0.0-rc.5 is amazing.Today I made a PR to revert the abolition of the type definition export of
RecordInstance<T>
that was deleted at that time. I usually use an abstract Class that inherits Record like the following repository.(using v4.0.0-rc.4)https://github.com/takefumi-yoshii/immutablejs-record-oop-example/blob/master/src/abstract.js
RecordFactory<T>
gives us simplicity, but without the definition ofRecordInstance<T>
, we can not extends SuperClass.That repository solved all type checks. Best regurd !