Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "& T" to some places where it's missing in RecordInstance #1464

Merged
merged 1 commit into from
May 17, 2018

Conversation

jedwards1211
Copy link
Contributor

@jedwards1211 jedwards1211 commented Dec 21, 2017

Not sure why it was missing from updateIn<U> or withMutations arguments.

Fix #1465

Not sure why it was missing from `updateIn<U>` or `withMutations` arguments
@kvanbere
Copy link

@leebyron it would be really good to have this, it's causing a bit of an issue for us. We have to put // $FlowFixMe above all our updateIn's which has caused some very real bugs for us.

@kvanbere kvanbere mentioned this pull request Mar 20, 2018
@leebyron leebyron merged commit 4ca6e19 into immutable-js:master May 17, 2018
@leebyron
Copy link
Collaborator

Makes sense, thanks for the fix

@kvanbere
Copy link

Thank you so much for merging this!

@leebyron leebyron added this to the 4.0 milestone May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants