reverse empty argument check in constructors #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most common way to call a constructor to make an empty collection is to call it without arguments, then value is undefined. With this commit the first check to see if the value passed to the constructor is not set is for undefined, the most common way to call it. This way the condition will only have to evaluate the left side for the common case.
|
Thanks @marianoguerra ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most common way to call a constructor to make an empty collection is to call it without arguments, then value is undefined.
With this commit the first check to see if the value passed to the constructor is not set is for undefined, the most common way to call it.
This way the condition will only have to evaluate the left side for the common case.