Fix List notSetValue not working for several key types #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,7 +57,7 @@ export class List extends IndexedCollection { | |||
|
|
|||
| get(index, notSetValue) { | |||
| index = wrapIndex(this, index); | |||
| if (index < 0 || index >= this.size) { | |||
| if (index < 0 || index >= this.size || index !== index) { | |||
There was a problem hiding this comment.
Rather than doing this, we can flip the if check and only do the get if it's safe, rather than short-circuiting.
|
I made the changes pointed out in the inline comments atop your rev, in case you want to inspect what changed. Thanks again for investigating this! |
|
See 8031a8b for final code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #486, using keys which can't be coerced to numbers in Lists ignored notSetValue. This pull request should hopefully solve that problem.